Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] portal_odoo_debranding: Migration to 17.0 #78

Merged
merged 13 commits into from
Sep 30, 2024

Conversation

NICO-SOLUTIONS
Copy link
Member

Standard Migration to 17.0

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review November 12, 2023 23:09
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Nov 12, 2023
4 tasks
@pedrobaeza
Copy link
Member

/ocabot migration portal_odoo_debranding

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 13, 2023
Copy link
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NICO-SOLUTIONS for porting this module.
Some minor comment related to XML tag not necessary anymore in index.html raising a WARNING during installation.
Apart from this, 👍

portal_odoo_debranding/static/description/index.html Outdated Show resolved Hide resolved
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review.
Functional test
LGTM

@sanderlienaerts
Copy link

Hi @legalsylvain, is it possible to get this one merged?

@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-78-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e2e8ee4 into OCA:17.0 Sep 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bdf76a9. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 17.0-mig-portal_odoo_debranding branch September 30, 2024 13:39
@NICO-SOLUTIONS
Copy link
Member Author

@yvaucher thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.